[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1510400:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev1.c: 2969 in ikev1_decode_peer_id()


________________________________________________________________________________________________________
*** CID 1510400:  Null pointer dereferences  (REVERSE_INULL)
/programs/pluto/ikev1.c: 2969 in ikev1_decode_peer_id()
2963     	}
2964     
2965     	struct id peer;
2966     
2967     	diag_t d = unpack_peer_id(id->isaid_idtype, &peer, &id_pld->pbs);
2968     	if (d != NULL) {
>>>     CID 1510400:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "st" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2969     		llog_diag(RC_LOG, LOGGER, &d, "%s", "");
2970     		return false;
2971     	}
2972     
2973     	if (c->spd.that.id.kind == ID_FROMCERT) {
2974     		/* breaks API, connection modified by %fromcert */

** CID 1510399:  Control flow issues  (DEADCODE)
/programs/pluto/ikev1.c: 1537 in process_v1_packet()


________________________________________________________________________________________________________
*** CID 1510399:  Control flow issues  (DEADCODE)
/programs/pluto/ikev1.c: 1537 in process_v1_packet()
1531     			return;
1532     		}
1533     
1534     		diag_t d = pbs_in_struct(&md->message_pbs, &isakmp_ikefrag_desc,
1535     					 &fraghdr, sizeof(fraghdr), &frag_pbs);
1536     		if (d != NULL) {
>>>     CID 1510399:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "md->md_logger" inside this statement: "llog_diag(RC_LOG, ((st != N...".
1537     			llog_diag(RC_LOG, LOGGER, &d, "%s", "");
1538     			SEND_NOTIFICATION(PAYLOAD_MALFORMED);
1539     			return;
1540     		}
1541     		if (pbs_room(&frag_pbs) != fraghdr.isafrag_length ||
1542     		    fraghdr.isafrag_np != ISAKMP_NEXT_NONE ||


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYjfB0_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ38SDI-2BR-2F3dLv7iLfdNpqhuX7WENDn1Mry9wS-2F7MhOZuHTXvOWCzKMIosBUepHJsx124F-2BfuinW3v-2FMoKwn2O-2Fe-2B2pu8sEKgu1NbZIb7utpcJYqMRZtoIuM7xMmuHQboeyoRbT-2F4devvAQ9lOVEoXGjVjlfgV-2FE3wdIj4VVy942i9SeDF59DKZIWxSZB4FxdXso-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiyFeP_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ38SDI-2BR-2F3dLv7iLfdNpqhuX7WENDn1Mry9wS-2F7MhOZuHU1wWgZAz9nUFVA4kAWP7WTQ-2B38HghTN1o3rBrNAZkOOpBZctFRA1f0F5SzJEAxA6Diet6AUcdhvTSXrdAM5M-2FuIbswZCSZCXCX1RU-2Fi8I6WkDLQVnXrniWIGk0QbRpdEO8-2BiwA3QSmATGimS3SAE2g-3D