[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1506250:  Security best practices violations  (DC.WEAK_CRYPTO)
/programs/pluto/ikev2_parent.c: 531 in schedule_v2_replace_event()


________________________________________________________________________________________________________
*** CID 1506250:  Security best practices violations  (DC.WEAK_CRYPTO)
/programs/pluto/ikev2_parent.c: 531 in schedule_v2_replace_event()
525     		marg = deltasecs(c->sa_rekey_margin);
526     
527     		switch (st->st_sa_role) {
528     		case SA_INITIATOR:
529     			marg += marg *
530     				c->sa_rekey_fuzz / 100.E0 *
>>>     CID 1506250:  Security best practices violations  (DC.WEAK_CRYPTO)
>>>     "rand" should not be used for security-related applications, because linear congruential algorithms are too easy to break.
531     				(rand() / (RAND_MAX + 1.E0));
532     			break;
533     		case SA_RESPONDER:
534     			marg /= 2;
535     			break;
536     		default:


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYpVbU_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FyobsJiiaBL1BQH84YgRcAxDKHRxkcErcGUOYQMbcaDTrho6kEW30Roq-2FA-2FrI6XMzJURkuAjQNRlUva74YGZ15GTY8Yv5Kve79KXa6KAdqRC6lfznksGrkBiJOOtIdxq6m4NilmqiV-2BKOLomkL1ohvb8m5XXL-2FVNNwXnYb6zeu3vsvwNkiuvO7TuyFXnk7Af8-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiLZEc_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2FyobsJiiaBL1BQH84YgRcAxDKHRxkcErcGUOYQMbcaDciwe-2FPTw8ryeNc8LpcTXohJtgSNc0LDvomIQzQsmDVqjb4GxLA8bQ-2BKK8fqNkzdSXRbWud8hhjXJZy11LruJpPPdM2IpvpCQO7a5gzQmFEqPa4sbNKhJ1fVSIqkpFZYsBhIiCxehpZnED9OVhoVtR8-3D