[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

2 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1497127:  Incorrect expression  (EVALUATION_ORDER)
/programs/pluto/connections.c: 799 in extract_end()


________________________________________________________________________________________________________
*** CID 1497127:  Incorrect expression  (EVALUATION_ORDER)
/programs/pluto/connections.c: 799 in extract_end()
793     		if (src->rsasigkey != NULL) {
794     			log_message(RC_LOG, logger,
795     				    "warning: ignoring %s rsasigkey '%s' and using %s certificate '%s'",
796     				    dst->leftright, src->cert,
797     				    dst->leftright, src->cert);
798     		}
>>>     CID 1497127:  Incorrect expression  (EVALUATION_ORDER)
>>>     In "cert = cert = get_cert_by_nickname_from_nss(src->cert, logger)", "cert" is written twice with the same value.
799     		CERTCertificate *cert = cert = get_cert_by_nickname_from_nss(src->cert, logger);
800     		if (cert == NULL) {
801     			log_message(RC_FATAL, logger,
802     				    "failed to add connection: %s certificate '%s' not found in the NSS database",
803     				    dst->leftright, src->cert);
804     			return -1; /* fatal */

** CID 1497126:  Incorrect expression  (NO_EFFECT)
/programs/pluto/log.c: 837 in string_logger()


________________________________________________________________________________________________________
*** CID 1497126:  Incorrect expression  (NO_EFFECT)
/programs/pluto/log.c: 837 in string_logger()
831     	/* construct the clone */
832     	struct logger logger = {
833     		.global_whackfd = dup_any(whackfd),
834     		.object_whackfd = null_fd,
835     		.where = where,
836     		.object_vec = &logger_string_vec,
>>>     CID 1497126:  Incorrect expression  (NO_EFFECT)
>>>     Comparing an array to null is not useful: "prefix == NULL", since the test will always evaluate as true.
837     		.object = clone_str(prefix, "string logger prefix"),
838     	};
839     	/* and clone it */
840     	return clone_thing(logger, "string logger");
841     }
842     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYWEUj_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ38HZZOetyBhAVIk79k3vJcFXahHGWGDibMhT-2Fwme56F6Ir7WiWB5Iq3y1bjNIdRHATWr47YTw9wvrtauJjuJlCJ5UOi8wqaB5QjVpgFKjsyGABA59vcUUJlY5OjXTuws83KgkjFbcgw0dRVyH5hgmd4pXxQ8V61tfeku09-2FXnJTO5jHtRRFi0gREhxbGKeYT-2Fk-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiXV9O_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ38HZZOetyBhAVIk79k3vJcFXahHGWGDibMhT-2Fwme56F6GoTRHkLDHKDYlIXW0FLifCX82kVYTna9rOKX2oqQC5P6b3kV7gbQT2g1Sd56GeYEPUvO5wmoQ7k9MKiwEf8u1dLfk5aMqEcA47IT2NiChaiO9gma6euC5eAhb-2FW2vOVM-2F7uqc0ssfhcqCicU9SRG94-3D