[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1497108:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1497108:  Null pointer dereferences  (FORWARD_NULL)
/programs/pluto/rcv_whack.c: 347 in key_add_request()
341     	err_t ugh = atoid(msg->keyid, &keyid); /* must free */
342     	if (ugh != NULL) {
343     		log_message(RC_BADID, logger, "bad --keyid \"%s\": %s", msg->keyid, ugh);
344     		return;
345     	}
346     
>>>     CID 1497108:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "type" to "key_add_request_1", which dereferences it.
347     	key_add_request_1(&keyid, type, msg, logger);
348     	free_id_content(&keyid);
349     }
350     
351     /*
352      * handle a whack message.


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kYiTEQ_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BBim4wdMIh7Nzip5KRNwhxaowUXTRx1iAaAOz7ookmfjWAVuikC8e3IHMXBcfyhdaryTCUhNgJAPGdzFZoCIsz0OiiYEeiEVCNwnGSGBd8U5-2FuEmfx9tzX1f1DRV5sKRc2Sa7j9PQ0JlclJyJgPRTeYpvdWW7HZOsGgoQ7cx4-2BgjLcmD1yRiG6UqALNvD-2FLsM-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxivy_B_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ3-2BBim4wdMIh7Nzip5KRNwhxaowUXTRx1iAaAOz7ookmflcei74Y1hxnUPJ6oaqu6118ZDHg0Nh9MotMk7po6icb8ZyDwIJoMX2MVSHQ-2BLLhR2PmNTxrMCStWVCR-2FBM9gXQRR7JWN46DhSxE9XfSL2d08yI2AXqgg3IkL2ul26Q7j3Z1gzfpw2-2F-2Fq017j9qZbaE-3D