[Swan-dev] testing: swan-prep break on conflicting config files

[Paul Wouters]

On Mon, 21 Sep 2020, Andrew Cagney wrote:

> Date: Mon, 21 Sep 2020 17:07:27
> From: Andrew Cagney <andrew.cagney at gmail.com>
> Cc: Libreswan Development List <swan-dev at lists.libreswan.org>
> To: Antony Antony <antony at phenome.org>
> Subject: Re: [Swan-dev] testing: swan-prep break on conflicting config files
> 
> 
> 
> On Mon, 21 Sep 2020 at 15:32, Antony Antony <antony at phenome.org> wrote:
>       Andrew,
>
>       after a closer look I see l2tp and ppp configuration file could be in the
>       form 'hostname + "." + config_file' in the test directory.
>
>       ikev1-l2tp-01/north.xl2tpd.conf
>
>       they are not copied using the function that got fixed in 1e0b14ec0b.
>        Now I am confused why this commit added 'hostname + "." + config_file'
>       That seems wrong to me. Why do we need it?
> 
> 
> Because northxl2tpd.conf is something I'd never guess.  There should be only two choices:
>    north.xl2tpd.conf
>    xl2tpd.conf

We only have 2 test cases with xl2tpd. Those tests should just start
xl2tpd with the custom config without copying it into /etc. That works
nicer on namespaces too.

Paul