[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

scan-admin at coverity.com scan-admin at coverity.com
Fri Oct 2 10:09:44 UTC 2020


Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1491599:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/pluto_crypt.c: 798 in stop_crypto_helpers()


________________________________________________________________________________________________________
*** CID 1491599:  Error handling issues  (CHECKED_RETURN)
/programs/pluto/pluto_crypt.c: 798 in stop_crypto_helpers()
792     			/* poke threads waiting for work */
793     			pthread_mutex_lock(&backlog_mutex);
794     			pthread_cond_signal(&backlog_cond);
795     			pthread_mutex_unlock(&backlog_mutex);
796     			/* wait for one to die; add timeout? */
797     			struct pluto_crypto_worker *w = NULL;
>>>     CID 1491599:  Error handling issues  (CHECKED_RETURN)
>>>     "read(int, void *, size_t)" returns the number of bytes read, but it is ignored.
798     			if (read(helper_exited.recv, &w, sizeof(w)) < 0 ||
799     			    w == NULL/*er!!!*/) {
800     				log_errno(logger, errno, "error reading helper exit pipe");
801     				/* give up; too much risk of a hang */
802     				return;
803     			}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq8aBKViEpsZ9KPFMeJd7kKMDjyzu82COVFw1h1aYx-2FtFrefiPxkohPqZgI7DsTRPR5L954NuJuE0J6c4ee-2B5kY7fuo_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39-2B1xJqWCoG6wPwvo6Pa-2BGLuywZ3XfnXB0BB5pi-2BHTd1WXYd2KUZb9-2F8AEKq1ESojjNdJdxAG1NA3B1eBpAzeMwiRJhnb5a-2BWxP-2F9WvN3vEWo5tJJuekHccr4-2BkSevWF-2FI8ayzFCA96RQ-2BMC3GA64HaeLA2pkjftqlG2pdmJJmMl8GOClOiSHgxAqw6m0vkhI8-3D

  To manage Coverity Scan email notifications for "swan-dev at lists.libreswan.org", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxUzCfl-2FUi6sRJtnGH1-2FWXEIl9xkb2JliKiAkqgdujeIgWYvUCIHO1g-2Ba8I-2B0nANYHmrw9-2B13a9hJ7YOPZRdlHcEQfoMvDvjqsfrRNzFQ8lscduvXP5RLkPig71dIKudxiSfaN_Cir5ZFqEb-2Fpy-2FZDdTxjwNXxDWd37ZfwlkdBT1REyQ39-2B1xJqWCoG6wPwvo6Pa-2BGLuywZ3XfnXB0BB5pi-2BHTd1Ry-2BheAFEaPfNzVpMPK0117s3wFT5zxXBrUZCo9TgEoRqEosemPCoIbbzzoMFaJ31erS002zMv0OusCszAdV1kRTOBDqe3Xgr1JduvNW9UWXq8gtS9GKxrp7f-2FCOvAqT-2B26p0cNQQtzJx1TKY6R3XWg-3D



More information about the Swan-dev mailing list