[Swan-dev] logging final pass

Andrew Cagney andrew.cagney at gmail.com
Mon Nov 30 20:07:14 UTC 2020


On Fri, 27 Nov 2020 at 15:36, Andrew Cagney <andrew.cagney at gmail.com> wrote:
>
> On Fri, 27 Nov 2020 at 12:44, Paul Wouters <paul at nohats.ca> wrote:
> >
> > On Wed, 25 Nov 2020, Andrew Cagney wrote:
> >
> > > Here's the current status.
> > >
> > > The standard log primitive is:
> > >
> > >   log_message(RC_FLAGS, logger, FMT, ...)
> >
> > > but this is all very tedious, so there are wrappers for common cases:
> > >
> > >  log_state(RC_LOG, &ike->sa, "hi!");
> >
> > Still a bit tedious :)
>
> we could have:
>    log_sa(RC_LOG, ike, "huh!");
> (especially if we assume 'st' is dying - I suspect all kernel code
> shoudl expect a child_sa).
>
> >
> > > - can log_message() be shortened?
> > > It can't be log() as that is taken by the math library, but llog() or
> > > (with irony) plog(), loglog() are now all free (or will be tomorrow)
> >
> > I would prefer llog() of those.
>
> sure.

I pushed this ...

I then looked at dbg_md() et.al.  and found that dbgl() (and for that
matter, logl()) roll off the tongue better than ldbg() (and llog() :-)
 So I pushed dbgl().


More information about the Swan-dev mailing list