[Swan-dev] Set keyingtries to 1 for Opportunistic Encryption connections

[Paul Wouters]

On Mon, 2 Mar 2020, D. Hugh Redelmeier wrote:

> Why would keyingtries have been set to something other than 1?

> Either it has the default (0) or something explicitly set by the user
> (which could be 0).

Indeed. The cases we encounter typically have the default.

> It seems to me that we should let the user set the value.  We certainly
> should not silently override a setting made by the user.

I agree. I added a log message.

> We should change the default for OE to 1.

Yes that's what I did with the quoted commit.

> At a minimum, if we override a value that the user specified, we
> should issue a diagnostic (warning? error?).

I agree, so I added it.

Paul