[Swan-dev] clarify ikev2_ts_r_desc length field

D. Hugh Redelmeier hugh at mimosa.com
Mon Mar 2 14:22:33 UTC 2020

I don't think that the logging change is good.

1. (almost?) all lengths in IKE are the length of the whole structure.
   By changing logging for only one, you raise more questions than you 
   answer.  "ft_len" means "length of the whole structure".

3. The result is quite wordy.

I suggest that if there are any lengths that are NOT of the whole 
structure, the logging should be changed for them.

| commit 054beecd614803522e62d30213e8be5b78205d30
| Author: Paul Wouters <pwouters at redhat.com>
| Date:   Sun Mar 1 22:12:42 2020 -0500
|     documentation: clarify ikev2_ts_r_desc length field
|     It's not the length of the variable part but of the entire TS structure.

More information about the Swan-dev mailing list