[Swan-dev] libipsecconf: promote ah= / esp= as desired keywords over phase2alg=

[Andrew Cagney]

On Mon, 29 Jun 2020 at 17:19, Paul Wouters <paul at vault.libreswan.fi> wrote:
>
> New commits:
> commit b98c10dc015c6c6bbc34c2020f7f5b20cf3483c8
> Author: Paul Wouters <pwouters at redhat.com>
> Date:   Mon Jun 29 17:16:47 2020 -0400
>
>     libipsecconf: promote ah= / esp= as desired keywords over phase2alg=
>
>     This is a reversal of what we tried to do in the past. Since IKEv2
>     does not really talk about phase2 anymore, this term is no longer
>     favoured.

Ya!

>     Ideally, phase2=ah|esp would also get renamed, but what word to use?
>
>     (type is already used for tunnel|transport, and mode= would be confused
>      with transport|tunnel mode. And encapsulation=ah would be weird because
>      there is no encapsulation. And no one wants ah=yes)

Right, mode is either transport or tunnel.
Encapsulation, however, refers to UDP / TCP.
(It's really confusing that the E in ESP is also encapsulate).
The RFC seems to refer to ESP and AH as child SAs (which does make sense).
>
> _______________________________________________
> Swan-commit mailing list
> Swan-commit at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-commit