[Swan-dev] regarding: testing: adding missing : ==== end ==== to nicinit

Paul Wouters paul at nohats.ca
Wed Jan 29 09:02:40 UTC 2020

On Tue, 28 Jan 2020, Andrew Cagney wrote:

>> final.sh has really been overloaded when what was needed was something running on east after the run.sh. We have the numbered .sh method for that now (especially if support for that is added to namespaces)
> I thought that worked.  The code's in fab/scripts.py.

There is a dependency somewhere to "detect" who is the responder.
Apparently that checks for *init.sh scripts and bails when it
cannot find it.

>> I do think things like checking for cores and audit logs can be done outside a .sh script.
>> But shutdown is something I wouldn’t want there because often you want to ssh into the test. Although if kvmrunner also will support —shutdown (and thus not shutting down), than that could be useful (eg stock runs always having leak-detective reports)
> The command:
>   kvmrunner one-test
> doesn't shutdown the domains.  The problem is that, to get and report
> a valid test result, all the .sh scripts need to be run - including
> final.sh and that unfortunately likes to kill libreswan.

Not often actually. Only a relatively few number of tests call shutdown,
and usually it is done to detect leaks.

> My idea is to replace final.sh with a teardown script that, unless
> there's a problem, leaves no trace in *.console.txt (but still spews
> all over *.console.verbose.txt so we can tell it ran).  That way:
>  kvmrunner one-test
> can skip the teardown but still report a "valid" result.
> If the teardown runs but doesn't make a sound ...

Sounds like a good plan.


More information about the Swan-dev mailing list