[Swan-dev] b52fc2d785 is not good fix

Paul Wouters paul at nohats.ca
Mon Feb 24 18:13:27 UTC 2020


On Mon, 24 Feb 2020, Antony Antony wrote:

> b52fc2d fix the build error it cause runtime segfault.

Thanks for letting me know. The caller of a kernel_ops entry is supposed
to check the function isn't NULL, but the call added to plutomain.c did
not do that. I fixed it.

> You need stub like Andrew added for BSD kernel_bsdkame.c c57088adef

That's not normally how we do kernel_ops. A lot of these are NULL, eg:

 	.process_queue = NULL,
 	.grp_sa = NULL,
 	.exceptsocket = NULL,
 	.remove_orphaned_holds = NULL, /* only used for klips /proc scanner */

Paul


More information about the Swan-dev mailing list