[Swan-dev] impair variable names

Antony Antony antony at phenome.org
Wed Apr 1 22:10:39 UTC 2020


On Mon, Mar 30, 2020 at 12:07:17PM -0400, Andrew Cagney wrote:
> I'm cleaning up the impair code.
> 
> Internally, the old style #define names are in upper case vis:
>   #define IMPAIR_REPLAY_FORWARD ...
> and
>   IMPAIR(REPLAY_FORWARD)
> while the new ones (that take parameters) are in lower case vis:
>   extern enum send_impairment impair_ike_key_length_attribute
> I've merged the two but preserved the names.
> 
> Should the names be made consistent?

that would be great.  go for it.

thanks,
-antony


More information about the Swan-dev mailing list