[Swan-dev] comment on version.mk - make rpm
Antony Antony
antony at phenome.org
Fri Oct 4 18:54:42 UTC 2019
a minor comment. I noticed a commit to fix version number in "make rpm"
https://github.com/libreswan/libreswan/commit/b68c5a33261ea07defa119edee97e4a495588d6c
It is good improvement to "make rpm".
However, there is another way to set pluto --version,
IPSECVERSION=%{IPSECVERSION}
https://github.com/libreswan/libreswan/blob/master/packaging/fedora/libreswan-testing.spec#L18
setting IPSECVERSION is also used in Debian and OpenWRT packaging. May be it
is better to use this method instead of b68c5a.
Having two different ways to set pluto --version is likely to end up in
trouble. Copying version.mk is possibly dificult to do in Debian or openwrt.
Debian run the make in place and not in seperate directory like ~/rpmbuild/
More information about the Swan-dev
mailing list