[Swan-dev] ace1aaf777 CentOS 6 addr_lookup.c:220: error: 'errno' undeclared

[Antony Antony]

I am writing this e-mail really amused(too many broken commits in the name 
of fixing) and annoyed when I wake up master is broken again! You are 
warned!

On Tue, Jun 18, 2019 at 04:04:52PM -0400, Andrew Cagney wrote:
> why is a library function calling printf()? (if a c file needs
> something #include it).

While these are good questions and good to explore, I can't seems to feel 
these questions are deflecting immediate issues, that I feel more important
in this thread.

1. why CentOS 6 catching these missing includes? why not the later 
GCC/Distributions?

2. The instance I pointed was changes to includes, which broke on some 
distribution and when pointed out those are not fixed in due time. I call it 
leaving master broken for for others while 'your greatest fix' is pushed.

I am a bit annoyed, because I feel I find Libreswan master broken too often
and get distracted from it. May be that is why I am overreacting a bit:)
I think it is everyone's interest to avoid these, contribute time to wider 
basic testing.

So I am continuing on this thread to remind us how a one line change you 
find greatest may cost time for others when they wake up and want continue 
what they were doing.

Now after venting my feelings, lets look at the new issue.

ace1aaf777 broke on CentOS6
on CentOS 6
USE_DNSSEC=false USE_NSS_IPSEC_PROFILE=flase make base
/home/build/libreswan/lib/libswan/addr_lookup.c: In function ‘netlink_query’:
/home/build/libreswan/lib/libswan/addr_lookup.c:220: error: ‘errno’ undeclared (first use in this function)
/home/build/libreswan/lib/libswan/addr_lookup.c:220: error: (Each undeclared identifier is reported only once
/home/build/libreswan/lib/libswan/addr_lookup.c:220: error: for each 
function it appears in.)

One could say fix one line and move on:) I guess that is what I going to do 
right after the e-mail.