[Swan-dev] testing: remove set -x from web-targets.mk

Andrew Cagney andrew.cagney at gmail.com
Mon Jul 29 20:20:24 UTC 2019


On Mon, 29 Jul 2019 at 15:58, Antony Antony <antony at phenome.org> wrote:

> On Mon, Jul 29, 2019 at 03:18:03PM -0400, Andrew Cagney wrote:
> > On Mon, 29 Jul 2019 at 14:27, Antony Antony <antony at phenome.org> wrote:
> >
> > > On Mon, Jul 29, 2019 at 11:31:30AM -0400, Andrew Cagney wrote:
> > > > On Mon, 29 Jul 2019 at 08:38, Andrew Cagney <andrew.cagney at gmail.com
> >
> > > wrote:
> > > >
> > > > > These make variables should only be expanded when web pages are
> > > enabled?
> > > > > Per the comment:
> > > > >
> > > > > # shortcuts to use when web is enabled, set up to evaluate once as
> > > > > # they can be a little expensive.  These make variable can only be
> > > > > # used inside of WEB_ENABLED blocks.
> > > > >
> > > >
> > > > In fact it was working.  Here's what happens in my tree using the
> commit
> > > > just before the below:
> > > >
> > > > $ v=$(gmake showversion)
> > > > $ echo $v
> > > > 3.28-506-g423d0e04bd-HEAD
> > > > $ v=$(make showversion LSW_WEBDIR=..)
> > > > + cd .
> > > > + git show --no-patch --format=%H HEAD
> > > > + testing/web/gime-git-description.sh .
> > > > $ echo $v
> > > > 3.28-506-g423d0e04bd-HEAD
> > > > $
> > > >
> > > > so I'm stumped as to why the below behaviour occurred.
> > >
> > > I added LSW_WEBDIR this month, this explains why I started to see
> change
> > > in
> > > behaviour of 'make showversion'. the commit that added set -x is old
> and I
> > > wondered why didn't I notice set -x before. Thanks for the information.
> > >
> > > 'make showversion' output should not change based on other variables
> are
> > > set
> > > or not! It is used by scripts.
> > >
> > > If you still want to see verbose, we a need different way without
> changing
> > > output of 'make showversion' or other targets used by scripts.
> > >
> > >
> > The output as in stdout and, as illustrated above, can be captured in a
> > shell variable, is unchanged.
> > Can you be more specific w.r.t., the problem you're seeing?
>
> two issues. it is annoying to see extra output when I expect short one
> line
> output.
> If we go down this path simple commands give overly complex output to read.
> This also affected make showdebversion, make showrpmversion..
>
>
Personally, I'd only use those and related packaging targets on a clean
tree with Makefile.inc.local empty.

second, I am using subprocess.getoutput() python function. which mixes
> stdout and stderror! I could replace this, the first reason still stands!
>
>
That seems very frail.


-antony
>
> > >
> > > >
> > > > Andrew
> > > >
> > > > At one point they were very expensive, unconditionally expanded, and
> > > > > repeatedly making everything slow.  Hence their verbosity - so we
> can
> > > see
> > > > > if the bug has crept back in
> > > > > (from memory, most of the expense was in computing 'dirty' which
> is why
> > > > > the web page code doesn't do that)
> > > > >
> > > > > Andrew
> > > > >
> > > > > ---------- Forwarded message ---------
> > > > > From: Antony Antony <antony at vault.libreswan.fi>
> > > > > Date: Mon, 29 Jul 2019 at 08:01
> > > > > Subject: [Swan-commit] Changes to ref refs/heads/master
> > > > > To: <swan-commit at lists.libreswan.org>
> > > > >
> > > > >
> > > > > New commits:
> > > > > commit 367867e7124949f029c5bf0b3b0f527384770bad
> > > > > Author: Antony Antony <antony at phenome.org>
> > > > > Date:   Sun Jul 21 11:08:10 2019 +0000
> > > > >
> > > > >     testing: remove set -x from web-targets.mk
> > > > >
> > > > >     after:
> > > > >     make showversion
> > > > >     3.28-504-g5113b92b34-master
> > > > >
> > > > >     before:
> > > > >     make showversion
> > > > >     + cd .
> > > > >     + git show --no-patch --format=%H HEAD
> > > > >     + testing/web/gime-git-description.sh .
> > > > >     3.28-504-g5113b92b34-dirty-master
> > > > >
> > > > > _______________________________________________
> > > > > Swan-commit mailing list
> > > > > Swan-commit at lists.libreswan.org
> > > > > https://lists.libreswan.org/mailman/listinfo/swan-commit
> > > > >
> > >
> > > > _______________________________________________
> > > > Swan-dev mailing list
> > > > Swan-dev at lists.libreswan.org
> > > > https://lists.libreswan.org/mailman/listinfo/swan-dev
> > >
> > >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20190729/4d513b79/attachment-0001.html>


More information about the Swan-dev mailing list