[Swan-dev] testing: remove set -x from web-targets.mk

Andrew Cagney andrew.cagney at gmail.com
Mon Jul 29 12:38:06 UTC 2019

These make variables should only be expanded when web pages are enabled?
Per the comment:

# shortcuts to use when web is enabled, set up to evaluate once as
# they can be a little expensive.  These make variable can only be
# used inside of WEB_ENABLED blocks.

At one point they were very expensive, unconditionally expanded, and
repeatedly making everything slow.  Hence their verbosity - so we can see
if the bug has crept back in
(from memory, most of the expense was in computing 'dirty' which is why the
web page code doesn't do that)


---------- Forwarded message ---------
From: Antony Antony <antony at vault.libreswan.fi>
Date: Mon, 29 Jul 2019 at 08:01
Subject: [Swan-commit] Changes to ref refs/heads/master
To: <swan-commit at lists.libreswan.org>

New commits:
commit 367867e7124949f029c5bf0b3b0f527384770bad
Author: Antony Antony <antony at phenome.org>
Date:   Sun Jul 21 11:08:10 2019 +0000

    testing: remove set -x from web-targets.mk

    make showversion

    make showversion
    + cd .
    + git show --no-patch --format=%H HEAD
    + testing/web/gime-git-description.sh .

Swan-commit mailing list
Swan-commit at lists.libreswan.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20190729/d5161eff/attachment.html>

More information about the Swan-dev mailing list