[Swan-dev] pluto: rename and remodularize emit_v2N*

Paul Wouters paul at nohats.ca
Sat Jan 5 05:35:11 UTC 2019


On Jan 5, 2019, at 00:27, Andrew Cagney <andrew.cagney at gmail.com> wrote:
>> 
> 
> Before I could look for emit_v2*() and failing that *_emit_*() and
> likely find the function needed to emit an IKEv2 payload.  Now I
> can't.  Instead, some are called out_*() - confusing them with the
> primitive out*() routines in packet.[hc] - and some are called
> emit_*().

All out_struct() using functions are called out_* so it makes sense to me, at least for the first one shipping a struct or chunk?

> Should we restore the above emit_v2() naming schema?

Seems like a bit of bikeshedding ? I don’t feel strongly about it



More information about the Swan-dev mailing list