[Swan-dev] pluto: simplify by changing ikev2_verify_psk_auth to return bool

[Andrew Cagney]

On Sun, 3 Feb 2019 at 12:44, D. Hugh Redelmeier <hugh at vault.libreswan.fi> wrote:
>
> New commits:
> commit 0ff22d6bbabf1539ce1565111c103701ff6c3520
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date:   Sun Feb 3 12:44:01 2019 -0500
>
>     pluto: add a ??? to v2_check_auth
>
> commit 7d870086d4e43d64c4a9a304b78e0e3b3c5329e7
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date:   Sun Feb 3 12:28:47 2019 -0500
>
>     pluto: simplify by changing ikev2_verify_psk_auth to return bool

Right.  I think this is far better than trying to return stf_status.
That function is too far removed from the state transition logic to
decide anything beyond true/false - it just ends up second guessing
and second guessing wrong.
And for the caller, the only real question is did auth succeed and,
hence can the state transition continue.

> commit b07914f7ddf0fa5cd56c21eede6035a99501d13b
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date:   Sun Feb 3 12:19:08 2019 -0500
>
>     pluto: fix typo in comment
>
> commit 9cbb2a02f97b8081a4437a8b72e930c183a0b2a8
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date:   Sun Feb 3 12:15:02 2019 -0500
>
>     pluto: ikev2_verify_psk_auth: improve diagnostic
>
> _______________________________________________
> Swan-commit mailing list
> Swan-commit at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-commit