[Swan-dev] calling loglog(RC_LOG_SERIOUS, ...) when processing a message

[Andrew Cagney]

On Fri, 13 Dec 2019 at 16:17, Paul Wouters <paul at nohats.ca> wrote:
>
>
>
> >>
> >> I guess the idea is that some code can be called with an administrator
> >> waiting at the whack socket, but sometimes the same code is timer
> >> triggered without an administrator.
> >
> > For some, yes.  The above is only triggered when a message arrives.
>
> That can still be one in response to a whack triggered up or rekey ?

For cases like that the whack handler passes the live WHACKFD into the
relevant function (rekey or initiate) which, in turn, dupes the FD and
stores the reference in the new sa's .st_whack_sock.

>From that point on code typically relies on [cur_state].st_whack_sock
being set to the new state when logging.

> > I
> > tend to suspect the more likely scenario is that no one is really sure
> > if/when whack is attached (cur_state, for instance, comes and goes) so
> > people were hedging their bets.
>
> I’m not sure that’s a bad thing? That’s the point of the design?
>
> Paul