[Swan-dev] revival, was Fwd: [Swan-commit] Changes to ref refs/heads/master

[Paul Wouters]

On Thu, 12 Dec 2019, Andrew Cagney wrote:

>> Aliased connections with auto=start must get revived. Similar for narrowing=yes connections which become instances.
>
> The revival code uses c->name as the connection identifier, not
> c->connalias.  So if a connection brought up using an alias goes down
> then c->name should re-find it.

Ah right. I dont like us depending on c->name for anything but yeah I
guess it does safe us here.

> However, for instances, things seem more interesting.  Is there a test
> I should look at?  My assumption was that by the time revival occurred
> the connection instance should be long gone?

Look at ikev2-allow-narrow-04. It installs a narrowed down IPsec SA, so
using an instance.

> (As an aside, conn_by_name() re-orders the connection list - so if
> both the conn and its instance were in the list then luck would
> determine which was found).

Hmm.

Paul