[Swan-dev] revival, was Fwd: [Swan-commit] Changes to ref refs/heads/master

[Andrew Cagney]

On Thu, 12 Dec 2019 at 14:50, Paul Wouters <paul at nohats.ca> wrote:
>
> This is not correct!
>
> Aliased connections with auto=start must get revived. Similar for narrowing=yes connections which become instances.

The revival code uses c->name as the connection identifier, not
c->connalias.  So if a connection brought up using an alias goes down
then c->name should re-find it.

However, for instances, things seem more interesting.  Is there a test
I should look at?  My assumption was that by the time revival occurred
the connection instance should be long gone?

(As an aside, conn_by_name() re-orders the connection list - so if
both the conn and its instance were in the list then luck would
determine which was found).

> Paul
>
> Sent from my iPhone
>
> Begin forwarded message:
>
> From: Andrew Cagney <cagney at vault.libreswan.fi>
> Date: December 12, 2019 at 14:38:09 EST
> To: swan-commit at lists.libreswan.org
> Subject: [Swan-commit] Changes to ref refs/heads/master
> Reply-To: swan-dev at lists.libreswan.org
>
> New commits:
> commit 1aef3b5d0c58b301afb49999d05aab92aade5d93
> Author: Andrew Cagney <cagney at gnu.org>
> Date:   Thu Dec 12 09:34:14 2019 -0500
>
>    revival: cleanup initiate_connection(), don't revive instances or aliases
>
>    Add separate initiate_connections_by_name().  Drop debug and impair
>    parameters.  Suppress futile whack_log() call - in revive_cons() there
>    is no whack.
>
> _______________________________________________
> Swan-commit mailing list
> Swan-commit at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-commit
>
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev