[Swan-dev] newoe-25-cat-3-4-way and our id=%any

[Andrew Cagney]

I'm puzzled by this failure:

--- MASTER/testing/pluto/newoe-25-cat-3-4-way/road.console.txt
+++ OUTPUT/testing/pluto/newoe-25-cat-3-4-way/road.console.txt
@@ -124,7 +124,7 @@
 000 "block":   policy: AUTH_NEVER+GROUP+GROUTED+REJECT+NEVER_NEGOTIATE;
 000 "block":   conn_prio: 32,32; interface: eth0; metric: 0; mtu:
unset; sa_prio:auto; sa_tfc:none;
 000 "block":   nflog-group: unset; mark: unset; vti-iface:unset;
vti-routing:no; vti-shared:no; nic-offload:no;
-000 "block":   our idtype: ID_IPV4_ADDR; our id=192.1.3.209; their
idtype: %none; their id=(none)
+000 "block":   our idtype: ID_IPV4_ADDR; our id=%any; their idtype:
%none; their id=(none)
 000 "block":   dpd: action:disabled; delay:0; timeout:0; nat-t:
encaps:no; nat_keepalive:no; ikev1_natt:both
 000 "block":   newest ISAKMP SA: #0; newest IPsec SA: #0;
 000 "clear": 192.1.3.209---192.1.3.254...%group; unrouted; eroute owner: #0

I'm not sure about this part:

if (e->id.kind == ID_NONE && !isanyaddr(&e->host_addr)) {
  e->id.kind = afi->id_addr;
  e->id.ip_addr = e->host_addr;
  e->id.isanyid = TRUE; /* used to match id=%any */ <- new line
  e->has_id_wildcards = FALSE;
}

of the change
https://github.com/libreswan/libreswan/commit/8bb225798220221396d63cb039d0f3dbb7fb739e

!isanyaddr() is true when !invalid && !any, i.e., an address was specified.

Andrew