[Swan-dev] redirect: in emit_redirect_notification_decoded_dest() delete '-' in column 1 negating a bool
D. Hugh Redelmeier
hugh at mimosa.com
Sat Aug 17 14:42:35 UTC 2019
| commit b473d2b9be0a244672aa2934e3feaac55ad23b82
| Author: Andrew Cagney <cagney at gnu.org>
| Date: Sat Aug 17 08:08:56 2019 -0400
|
| redirect: in emit_redirect_notification_decoded_dest() delete '-' in column 1 negating a bool
|
| Looks like a merge botch. Worryingly, fixing this doesn't seem to
| affect test results - it would have caused the initiator code path
| to always fail?
|
| See 4e3d1805639c05e3fd00c4d175979916111476b5
Good catch! Thanks.
Interestingly, in C, applying "-" to a bool does not change the value
if it is used as a bool.
a: false true
-a: 0 -1
(bool) -a: false true
So: no testing could find this bug since it causes no difference in
behaviour.
More information about the Swan-dev
mailing list