[Swan-dev] New Defects reported by Coverity Scan

[Antony Antony]

Hi,

Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.

1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1473600:  Resource leaks  (RESOURCE_LEAK)
/lib/libswan/secrets.c: 1450 in allocate_ECDSA_public_key_nss()


________________________________________________________________________________________________________
*** CID 1473600:  Resource leaks  (RESOURCE_LEAK)
/lib/libswan/secrets.c: 1450 in allocate_ECDSA_public_key_nss()
1444     	keyblobtoid((const unsigned char *)keyid, KEYID_BUF,
1445     		    pk->u.ecdsa.keyid, KEYID_BUF);
1446     
1447     	/* ckaid */
1448     	err_t err =form_ckaid_ecdsa(pub, &ckaid);
1449     	if (err != NULL)
>>>     CID 1473600:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pk" going out of scope leaks the storage it points to.
1450     		return NULL;
1451     
1452     	pk->u.ecdsa.ckaid = ckaid;
1453     	/*
1454     	 * based on comments in form_keyid, the modulus length
1455     	 * returned by NSS might contain a leading zero and this


________________________________________________________________________________________________________