[Swan-dev] Git Breakage - blapi.h (fwd)

[António Silva]

thanks, i also find the solution for the other issue:

https://github.com/libreswan/libreswan/commit/b3199806cc66de4888917ddc85b511b433e43d63

"building: -lfreebl is no longer needed "


would you merge this changes into 3.26 or we will see 3.27? :)


On 19/09/2018 15:59, Andrew Cagney wrote:
> https://github.com/libreswan/libreswan/commit/910f69119b491c6d7abcc85cf8911d2fa012a135
>
> ecdsa: don't include NSS's "blapi.h", no longer needed and not on debian
>
> (not to be confused with "lbapit.h", which also looks suspect)
>
> Follow-up b319980 and
> 2d093c9.  The latter
> relaced the call to ECDSA_VerifyDigest() with PK11_Verify().
>
> (b319980 droped the link line)
> On Wed, 19 Sep 2018 at 08:39, Lennart Sorensen
> <lsorense at csclub.uwaterloo.ca> wrote:
>> On Wed, Sep 19, 2018 at 08:34:53AM -0400,  wrote:
>>> I think the library is called libfreebl3 on Debian, so change -lfreebl
>>> to -lfreebl3 and see if that helps.
>>>
>>> Debian does not put up with upstreams that don't understand how to
>>> version their ABIs and will do it for them if necesary.
>>>
>>> Looking at the source for nss, blapit.h is listed in manifest.mn as
>>> EXPORT.  blapi.h is listed as PRIVATE_EXPORTS.  Debian ships the public
>>> headers, not the private ones.  So either nss is wrong in flagging it
>>> as private, or libreswan is wrong in trying to use a private header file.
>>> My initial guess would be the last option.
>> Looking at the git history it looks like blapi.h was made private and not
>> supposed to be used by others in 2003.  So yeah libreswan should not be
>> including it.  Including blapit.h is the one used by public header files.
>>
>> https://github.com/nss-dev/nss/commit/aee02a249f905e907784536b6f5ebe876bf26021
>>
>> --
>> Len Sorensen
>> _______________________________________________
>> Swan-dev mailing list
>> Swan-dev at lists.libreswan.org
>> https://lists.libreswan.org/mailman/listinfo/swan-dev

-- 
Saludos / Regards / Cumprimentos
António Silva