[Swan-dev] we should not delete tests before we delete the code they test
andrew.cagney at gmail.com
Fri Oct 26 16:05:18 UTC 2018
I changed the following:
- unless USE_KLIPS=true, 'make module' barfs
- eliminated a USE_KLIPS=true lurking in mk/defaults/linux.mk, KLIPS
wasn't really disabled
- the testsuite no longer builds the modules (unless USE_KLIPS)
- libreswan no longer shares code with klips, so linux/ can be deleted
On Tue, 23 Oct 2018 at 12:22, Andrew Cagney <andrew.cagney at gmail.com> wrote:
> On Tue, 23 Oct 2018 at 04:38, Paul Wouters <paul at nohats.ca> wrote:
> > On Mon, 22 Oct 2018, Andrew Cagney wrote:
> > > Do we still need to build the klips kernel module while testing (I'm
> > > guessing it is no longer used).
> > No. In fact, when we compile without USE_KLIPS, building the module
> > should not work or should be refused.
> OK. It is best to assume that hence forth the kernel module no longer builds.
> (I just had to patch up what looked like a simple tweak so the klips
> kernel module built. Once the kernel is disabled I'll stop seeing
> this so things will very quickly break).
More information about the Swan-dev