[Swan-dev] we should not delete tests before we delete the code they test

Andrew Cagney andrew.cagney at gmail.com
Mon Oct 22 13:37:00 UTC 2018


Do we still need to build the klips kernel module while testing (I'm
guessing it is no longer used).

On Sun, 21 Oct 2018 at 16:23, Paul Wouters <paul at nohats.ca> wrote:
>
> On Sun, 21 Oct 2018, D. Hugh Redelmeier wrote:
>
> > We no longer test KLIPS.  Not only that, the tests have been deleted, not
> > just disabled. 7c5c71b34bcc9dc3db7e24fb63a4a99aa927a72a
>
> Tests were already mostly disabled by everyone running tests.
>
> > I think that it is a Bad Idea to ship KLIPS code if we don't test it.
>
> It is only like that for 1 or 2 releases, as we agreed in the Toronto
> meeting. Then the code will be removed. It is "unsupported" now.
>
> > Recommendation: KLIPS tests should be restored OR KLIPS should be deleted.
> > Now.
>
> What is the point of having the tests when:
> - The core devs disable them
> - No one looks (or have looked for a while) at the test output
> - Developers don't want to support it, test it or run it.
> - No one will fixup failing tests
>
> I think this is a clear signal that KLIPS is really going to be removed
> soon. The time to migrate away from KLIPS is now.
>
> Paul
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev


More information about the Swan-dev mailing list