[Swan-dev] Fwd: [Swan-commit] Changes to ref refs/heads/master

[Paul Wouters]

On Wed, 21 Nov 2018, Andrew Cagney wrote:

>> 1. Me like ikev2_ (firs prefix) function names. Just v2 is confusing to me. It could be v2 of something else. nss.. also v2 preix appears at various positions. Some times as the first prefix, other times in the middle. Just some functions we have v2 versions. However, this has been going on for while, possibly too late to change.
>
> I believe the, er, guidance we were given was to use the shorter v[12].

I think we did agree on that?

>> ikev2_message.h  25 struct ike_sa;
>
> this is normal C
>
>> state.c         539 struct ike_sa *ike_sa(struct state *st)
>
> I don't know, the convention object name == constructor/cast name is
> very common in OO
> and any alternative would be longer :-(

I have rewritten some of these so the names are different. I strongly
dislike it too because it is no longer obvious to me what is a struct
definition and what is a variable of it.

Paul