[Swan-dev] interop-ikev2-strongswan-39-mobike-responder puzzle

[Andrew Cagney]

On Sun, 4 Nov 2018 at 14:44, Andrew Cagney <andrew.cagney at gmail.com> wrote:

> In the logs, first the CP payload's first address 192.0.3.1 is used
> (matching above):
>
> | #2 road-eastnet[1] parsing ISAKMP_NEXT_v2CP payload
> ...
> "road-eastnet"[1] 192.1.2.23 #2: received INTERNAL_IP4_ADDRESS 192.0.3.1

ikev2_set_ia() sets c->spd.this.client unconditionally to 192.0.3.1
since c->spd.this.host_srcip is empty it too is updated / logged:

> | setting host source IP address to 192.0.3.1

> ...
> "road-eastnet"[1] 192.1.2.23 #2: received INTERNAL_IP4_ADDRESS 192.0.3.2

ikev2_set_ia() sets c->spd.this.client unconditionally to 192.0.3.2
since c->spd.this.host_srcip was updated above, that isn't updated / logged

If nothing else, the code shouldn't be setting c->spd.this.client and
c->spd.this.host_srcip to different values.  Fixing ...

Andrew