[Swan-dev] clanger: ikev2_resp_accept_child_ts

[Antony Antony]

On Sun, Jun 10, 2018 at 05:16:51PM -0400, D. Hugh Redelmeier wrote:
> (1) it isn't clear to me why the streq(best->name, t->name) is not negated
> 
> Could someone add a comment expaining this?  Paul?  Antony?

I don't recognize this code.  git blame points to commit adefd63e ? 
Did I commit the following code?

> 
> 929	if (LIN(POLICY_GROUPINSTANCE, t->policy) && (t->kind == CK_TEMPLATE)) {
> 930		/* ??? clang 6.0.0 thinks best might be NULL but I don't see how */
> 931		if (!streq(t->foodgroup, best->foodgroup) ||
> 932		    streq(best->name, t->name) ||
> 933		    !subnetinsubnet(&best->spd.that.client, &t->spd.that.client) ||
> 934		    !sameaddr(&best->spd.this.client.addr, &t->spd.this.client.addr))
> 935			continue;
> 936
> 937		/* ??? why require best->name and t->name to be different */

I ran clang after a while, from what I recollect scan-build issues list is short!
Special thanks to your persistance. The code is probably getting better.

-antony