[Swan-dev] Coverity Scan thinks complete_v1_state_transition smells

[D. Hugh Redelmeier]

void complete_v1_state_transition(struct msg_digest **mdp, stf_status result)
{
	struct msg_digest *md = *mdp;
	passert(md != NULL);

	...

	switch (result) {
	case STF_SUSPEND:
		set_cur_state(md->st);	/* might have changed */
		if (*mdp != NULL) {

How could *mdp be NULL?

(If I remember correctly, many years ago that could happen.  It was part
of the signal from the state transition function to
complete_v1_state_transition that md should not be freed.  But much
has changed since then.)

Andrew: the closest fingerprints are yours.  Can you have a look?