[Swan-dev] confread diagnostics [was: Re: [Swan-commit] Changes to ref refs/heads/master]

[Paul Wouters]

On Mon, 9 Jul 2018, D. Hugh Redelmeier wrote:

> In libipsecconf, diagnostics don't really appear to follow a pattern
> that makes sense to me.  Furthermore, I think that how logging should
> be done (printf, fprintf to stderr, syslog) depends on something
> really high and I suspect that that is being botched.

It's the old duplicate logging functions issues. Even if you use the
same functions to log as in pluto, you have to fake some pluto state
and end up with those kludges like exit_tool() and all. And the log
functions need to be smart about knowing when it is called from pluto
or like addconn (since the functions are shared by both).

We've tried to just pass errors (ugh) up the chain. the original starter
code used printf()s to log

I'd rather not increase/add complexity in the logging functions for
these and try keeping to passing ugh error strings up the chain.

Paul