[Swan-dev] [Swan-commit] Changes to ref refs/heads/master
Andrew Cagney
andrew.cagney at gmail.com
Mon Jul 9 13:45:47 UTC 2018
Just pass in a stack allocated lswlog
On Mon, 9 Jul 2018 at 02:06, D. Hugh Redelmeier <hugh at vault.libreswan.fi> wrote:
>
> New commits:
> commit f28c65e2c5a132562172522a73c88a2fcf4a841e
> Author: D. Hugh Redelmeier <hugh at mimosa.com>
> Date: Mon Jul 9 01:55:40 2018 -0400
>
> confread: more carefully handle diagnostics
>
> Problems:
>
> - err_t was used for mutable errors
>
> + for heap-allocated strings: leaks
>
> + for static-allocated buffers: contents might be overwritten
>
> - multiple errors might cause all but the last to be discarded
>
> - some errors might get lost because they were treated as non-fatal
>
> Solution:
>
> - use a new mechanism for accumulating heap-allocate messages: starter_errors_t
>
> - the messages are printed even if the condition isn't considered fatal
>
> _______________________________________________
> Swan-commit mailing list
> Swan-commit at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-commit
More information about the Swan-dev
mailing list