[Swan-dev] [PATCH libreswan v2] netlink: Silence negative shift coverity false warning

Antony Antony antony at phenome.org
Fri Sep 22 13:21:27 UTC 2017

On Fri, Sep 15, 2017 at 11:17:43PM -0400, D. Hugh Redelmeier wrote:
> | From: Antony Antony <antony at phenome.org>
> coverity-detected anomalies are sometimes subtle.  So I looked at this
> code and found a couple of bugs.  I also did some tidying.  But no
> testing!
> Aviv, Antony: please have a look at commit
> f7aaa80198851ef71da4be8dc54e816f7064e29a
> Note: % 31 is almost never correct.  I think that in this code, + 31 is 
> also wrong.

Thanks DHR. This commit looks good to me. It address my concerns too.

> Could someone with real hardware test this code?

not me. I have no acess to the real hardware to test.


More information about the Swan-dev mailing list