[Swan-dev] defaulting libreswan build to linux

[Andrew Cagney]

On 11 October 2017 at 15:03, Paul Wouters <paul at nohats.ca> wrote:

> On Wed, 11 Oct 2017, Andrew Cagney wrote:
>
> I'm considering merging much of mk/defaults/linux.mk into mk/config.mk so
>> that config.mk just defaults everything to the typical
>> linux value.
>> This would mean removing the esoteric checks for other OS variants - if
>> an OS needs those overrides then they can be added to
>> mk/defaults/$(OS).mk (when was libreswan built on anything other than
>> linux?)
>>
>> (oh, and delete mk/defaults/debian.mk)
>>
>
> One requirement would still be for me that people can look at one file
> and easilly configure their OS. So I would still like the top of the
> file to allow for uncommenting an include for another OS.
>
>
Right, mk/config.mk is already somewhat like that and in that sense
wouldn't change. Near the top it pulls on per-OS defaults from
mk/defaults/$(BUILDENV).mk and then it proceeds to fill in defaults.
Mostly, sort of, except ... for instance it contains:

# Build support for the Linux Audit system
ifeq ($(OSDEP),linux)
USE_LINUX_AUDIT?=false
endif

which should be just:

# Build support for the Linux Audit system
USE_LINUX_AUDIT?=false

(mk/defaults/linux.mk has magic to enable it on fedora hosts) Its those
strange quirks I'd be getting rid of.

(as an aside the best way I've found for integrating libreswan into
esoteric build systems was to specify the relevant USE_* flags directly on
the make line)


I dont much care on how that works under the hood.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libreswan.org/pipermail/swan-dev/attachments/20171013/088dde1f/attachment.html>