[Swan-dev] crash after pluto: Fix addresspool reference count

[Antony Antony]

Hi Wolfgang,

Thanks for the config so far I only looked at test run result.

Test run shutdown crash after Paul applied the patch bd3a5f01e7c5c7ced
Here is the backtrace I see:
https://swantest.libreswan.fi/results/blackswan/2017-10-03-swantest-3.22dr2-487-gaa90cdeb8-master/xauth-pluto-16/OUTPUT/east.core.txt

Could please get some more information?
Are you running 3.21 + patch or librewan master? Could you do a quick test 
with your patch "ipsec stop". Does it crash? 

If it does not crash not crash for you, please another test with 
"plutodebug=all" 

Just bring up the connection and "ipsec stop"

regards,
-antony

On Thu, Oct 05, 2017 at 09:45:02AM +0200, Wolfgang Nothdurft wrote:
> Am 02.10.2017 um 13:58 schrieb Antony Antony:
> > Hi Paul
> > 
> > A quick test after the commit bd3a5f01 show a crash in test xauth-pluto-16
> > pointing to addresspool.c. The crash happens with ipsec stop
> > 
> > I couldn't repoduce lsw#299 yet. Did you manage to reproduce before bd3a5f0
> > patch?
> > 
> 
> Am 02.10.2017 um 13:58 schrieb Antony Antony:
> > Hi Paul
> >
> > A quick test after the commit bd3a5f01 show a crash in test xauth-pluto-16
> > pointing to addresspool.c. The crash happens with ipsec stop
> >
> > I couldn't repoduce lsw#299 yet. Did you manage to reproduce before
> bd3a5f0
> > patch?
> 
> There seems a general problem with the reference code in addresspool, which
> comes up with the latest changes.
> 
> I can reproduce the problems very easy with two xauth clients connecting to
> the same connection.
> 
> My test server config:
> 
> conn xauth_0-client_sn-sn_192.168.11.0/24-0.0.0.0/0
>         also=xauth_0-client
>         leftsourceip=192.168.11.1
>         leftsubnet=192.168.11.0/24
>         right=%any
>         auto=add
>         rekey=no
> conn xauth_0-client
>         left=%defaultroute
>         pfs=yes
>         compress=no
>         disablearrivalcheck=no
>         salifetime=540m
>         ikelifetime=360m
>         authby=secret
>         xauthby=file
>         leftxauthserver=yes
>         rightxauthclient=yes
>         leftmodecfgserver=yes
>         rightmodecfgclient=yes
>         modecfgpull=yes
>         rightaddresspool=192.168.11.100-192.168.11.110
> 
> Wolfgang