[Swan-dev] crash after pluto: Fix addresspool reference count

[Wolfgang Nothdurft]

Am 02.10.2017 um 13:58 schrieb Antony Antony:
> Hi Paul
> 
> A quick test after the commit bd3a5f01 show a crash in test xauth-pluto-16
> pointing to addresspool.c. The crash happens with ipsec stop
> 
> I couldn't repoduce lsw#299 yet. Did you manage to reproduce before bd3a5f0
> patch?
> 

Am 02.10.2017 um 13:58 schrieb Antony Antony:
 > Hi Paul
 >
 > A quick test after the commit bd3a5f01 show a crash in test 
xauth-pluto-16
 > pointing to addresspool.c. The crash happens with ipsec stop
 >
 > I couldn't repoduce lsw#299 yet. Did you manage to reproduce before 
bd3a5f0
 > patch?

There seems a general problem with the reference code in addresspool, 
which comes up with the latest changes.

I can reproduce the problems very easy with two xauth clients connecting 
to the same connection.

My test server config:

conn xauth_0-client_sn-sn_192.168.11.0/24-0.0.0.0/0
         also=xauth_0-client
         leftsourceip=192.168.11.1
         leftsubnet=192.168.11.0/24
         right=%any
         auto=add
         rekey=no
conn xauth_0-client
         left=%defaultroute
         pfs=yes
         compress=no
         disablearrivalcheck=no
         salifetime=540m
         ikelifetime=360m
         authby=secret
         xauthby=file
         leftxauthserver=yes
         rightxauthclient=yes
         leftmodecfgserver=yes
         rightmodecfgclient=yes
         modecfgpull=yes
         rightaddresspool=192.168.11.100-192.168.11.110

Wolfgang