[Swan-dev] [PATCH libreswan] Add support for IPSec HW-offload on the NIC

[Ilan Tayari]

> -----Original Message-----
> From: Antony Antony [mailto:antony at phenome.org]
> Subject: Re: [Swan-dev] [PATCH libreswan] Add support for IPSec HW-offload
> on the NIC
> 
> Hi Ilan,
> Here are a couple of proposed changes, untested, after a closer review.
> 
> 1. rename option to "nic-offload". Libreswan is moving away from "_"
> 2. whack --nic-offload
> 3. nic-offload:yes;  in "ipsec staus" connection
> 4. there is one coding style change I made.
> 
> On Wed, Jun 28, 2017 at 05:31:06AM +0000, Ilan Tayari wrote:
> > > I guess this is could be applied. However, please hold on, lets update
> > > xfrm.h first.
> > >
> > > I plan to update linux26/xfrm.h with history from kernel commits.
> > > It should happen before this patch. Otherwise it hard to know how upto
> > > date
> > > xfrm.h is.
> 
> > Yes, I suppose xfrm.h update should come separately and before.
> > I don't mind rebasing and re-submitting after you do that.
> > Do you have an approximation when this would happen?
> 
> I pushed this change yesterday. Rebase should work.

Great, thanks!

> 
> > > Another comment. It would be nice to add whack option?
> >
> > I'll take some time to understand whack better and come up with
> something.
> > You're talking about the command line tool, right?
> 
> see the attached proposed patch. It is not tested, I don't have a card.

I'll take a look and test it.
Thanks a lot!

> 
> regards,
> -antony