[Swan-dev] [libreswan RFC 1/3] kernel_netlink: Detect netlink SA failures

Tuomo Soini tis at foobar.fi
Tue Jul 25 07:18:46 UTC 2017


On Tue, 11 Jul 2017 18:09:05 +0300
ilant at mellanox.com wrote:

> From: Ilan Tayari <ilant at mellanox.com>
> 
> If the kernel responds with an error to NEWSA or DELSA,
> current code disregards this.
> Detect failures and return a proper value to the caller.
> 
> This is required for nic-offload-fallback to work.
> 
> Signed-off-by: Ilan Tayari <ilant at mellanox.com>

I suggest checking coding style of these patches. You can use
checkpatch.pl from kernel sources to check.

checkpatch.pl --no-tree 0001-your-changes.patch

There are several errors in this patch set.

-- 
Tuomo Soini <tis at foobar.fi>
Foobar Linux services
+358 40 5240030
Foobar Oy <http://foobar.fi/>


More information about the Swan-dev mailing list