[Swan-dev] cavp question

Andrew Cagney andrew.cagney at gmail.com
Mon Aug 21 16:59:42 UTC 2017

On 20 August 2017 at 00:02, D. Hugh Redelmeier <hugh at mimosa.com> wrote:
> This code in testing/cavp/cavp_ikev1.c looks fishy:
>        if (prf == NULL) {
>                 print_line(prf->key);
>                 return;
>         }
> My best guess is that the test is suposed to be:
>        if (prf->prf == NULL) {

Yes.  Here, prf is never NULL, but prf->prf could be.

If someone feeds SHA-224, which we don't support into CAVP, then it
will dump core instead of stumbling on.  The test facility shouldn't
be doing that anyway :-)

I'll change to code and get rid of the indirection.


> But I am quite unsure.
> Can someone look at this?
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev

More information about the Swan-dev mailing list