[Swan-dev] [PATCH libreswan v2 3/3] kernel, netlink: Add support for nic_offload='auto' mode

Paul Wouters paul at nohats.ca
Sun Aug 6 23:54:50 UTC 2017

On Sun, 6 Aug 2017, Ilan Tayari wrote:

>> libreswan code do not treat pointers as boolean; atleast try to avoid it.
>> the above line would something like :
>> c->interface != NULL || c->interface->ip_dev != NULL ||
>> c->interface->ip_dev->id_rname != NULL
>> There are a few more cases where pointer is used as boolean, it will good
>> to
>> clean up. I have pointed this out in the previous reviews.
> Sorry about that. I forgot.
> Context-switching between project conventions has its cost :/
> Did you fix this in master too?

AFAIK, those were all fixed in current git master.


More information about the Swan-dev mailing list