[Swan-dev] [PATCH libreswan v2 2/3] pluto, whack: Add nic-offload 'auto' mode

[Ilan Tayari]

> -----Original Message-----
> From: Antony Antony [mailto:antony at phenome.org]
> Subject: Re: [PATCH libreswan v2 2/3] pluto, whack: Add nic-offload 'auto'
> mode
> 
> > +enum nic_offload_options {
> > +	nic_offload_no = 0,
> 
> the feed back I sent used nic_offload_no = 1
> that is less confusing. Most vaules get zeroed so preferably start from 1.
> 
> > +	nic_offload_yes = 1,
> > +	nic_offload_auto = 2,
> > +};

Right. 

> >  		case CD_NIC_OFFLOAD:  /* --nic-offload */
> > -			msg.nic_offload = TRUE;
> > +			if (streq(optarg, "no"))
> > +				msg.nic_offload = nic_offload_no;
> > +			else if (streq(optarg, "yes"))
> > +				msg.nic_offload = nic_offload_yes;
> > +			else if (streq(optarg, "auto"))
> > +				msg.nic_offload = nic_offload_auto;
> > +			else
> > +				diag("--nic_offload options are 'no', 'yes' or
> 'auto'");
> 
> the last line diag should be "--nic-offload" ?
> 

Right again.

Did you fix both things in the merged patch in master?

Ilan.