[Swan-dev] [Swan] Multiple clients behind the same NAT IP get dropped - IPSec / xauth

[Lennart Sorensen]

On Tue, Aug 23, 2016 at 02:22:56PM -0400, Paul Wouters wrote:
> On Tue, 28 Jun 2016, Schmidt, Michael M wrote:
> 
> >I can run a debug if you tell me what debug level to run on and what version you want me to test with.
> 
> Antony located a bug that I think might have caused this problem.
> Try this small patch:
> 
> diff --git a/programs/pluto/connections.c b/programs/pluto/connections.c
> index 7a5b1a2..bcb73a7 100644
> --- a/programs/pluto/connections.c
> +++ b/programs/pluto/connections.c
> @@ -1819,6 +1821,9 @@ char *add_group_instance(struct connection *group, const i p_subnet *target)
> 
>  		t->spd.reqid = group->spd.reqid == 0 ?
>  			gen_reqid() : group->spd.reqid;
> +		t->spd.reqid =  gen_reqid(); + +
> 
> 		/* add to connections list */
> 		t->ac_next = connections;

That doesn't look like valid syntax with all those '+'

And that line seems like it overrides the previous like, so what is the
point in doing that?

-- 
Len Sorensen