[Swan-dev] missing make dependencies

[Andrew Cagney]

On 8 August 2016 at 13:39, Antony Antony <antony at phenome.org> wrote:
> here is a report of missing make dependencies.
>
> Over the weekend I tracked down a couple missing make dependencies. Some of them are hard to trackdown when compiling over 9pfs or nfs...
>
> 1. addconn is missing dependency on lib/libipsecconf/keywords.c.   Seee below to reproduce.

Thanks for the reproducer.

> 2. make base or programs seems to miss dependency on Makefile.inc.local and possibly other Makefiles too?

I'm not sure what you mean.

> ## how to reproduce  ##
> rm -fr OBJ.linux.x86_64
> make base 2>&1 > /dev/null
> ls -l OBJ.linux.x86_64/programs/addconn/addconn
> md5sum OBJ.linux.x86_64/programs/addconn/addconn
> ls -l lib/libipsecconf/keywords.c
> sleep 62
> sed -i 's/narrowing/nonarrowing/' lib/libipsecconf/keywords.c
> ls -l lib/libipsecconf/keywords.c
> make base 2>&1 > /dev/null
> ls -l OBJ.linux.x86_64/programs/addconn/addconn
> md5sum OBJ.linux.x86_64/programs/addconn/addconn
> git diff
> #end of commands
>
> Here is what I see : notice OBJ.linux.x86_64/programs/addconn/addconn didn't get build after change to lib/libipsecconf/keywords.c
> [build at blueswan libreswan]$ ## send me output of these ##
> [build at blueswan libreswan]$ rm -fr OBJ.linux.x86_64
> [build at blueswan libreswan]$ make base 2>&1 > /dev/null
> [build at blueswan libreswan]$ ls -l OBJ.linux.x86_64/programs/addconn/addconn
> -rwxrwxr-x. 1 build build 508152 Aug  7 21:05 OBJ.linux.x86_64/programs/addconn/addconn
> [build at blueswan libreswan]$ md5sum OBJ.linux.x86_64/programs/addconn/addconn
> e6895fa0e0d2751997b4747b6dc3fb3f  OBJ.linux.x86_64/programs/addconn/addconn
> [build at blueswan libreswan]$ ls -l lib/libipsecconf/keywords.c
> -rw-rw-r--. 1 build build 30676 Aug  7 21:01 lib/libipsecconf/keywords.c
> [build at blueswan libreswan]$ sleep 62
> [build at blueswan libreswan]$ sed -i 's/narrowing/nonarrowing/' lib/libipsecconf/keywords.c
> [build at blueswan libreswan]$ ls -l lib/libipsecconf/keywords.c
> -rw-rw-r--. 1 build build 30678 Aug  7 21:06 lib/libipsecconf/keywords.c
> [build at blueswan libreswan]$ make base 2>&1 > /dev/null
> [build at blueswan libreswan]$ ls -l OBJ.linux.x86_64/programs/addconn/addconn
> -rwxrwxr-x. 1 build build 508152 Aug  7 21:05 OBJ.linux.x86_64/programs/addconn/addconn
> [build at blueswan libreswan]$ md5sum OBJ.linux.x86_64/programs/addconn/addconn
> e6895fa0e0d2751997b4747b6dc3fb3f  OBJ.linux.x86_64/programs/addconn/addconn
> [build at blueswan libreswan]$ git diff
> diff --git a/lib/libipsecconf/keywords.c b/lib/libipsecconf/keywords.c
> index 42a5088..a15fee6 100644
> --- a/lib/libipsecconf/keywords.c
> +++ b/lib/libipsecconf/keywords.c
> @@ -486,7 +486,7 @@ const struct keyword_def ipsec_conf_keywords_v2[] = {
>    { "ike_frag",  AUTO | kv_processed | kv_alias,  kt_enum,  KBF_IKE_FRAG,  &kw_ynf_list },  /* obsolete _ */
>    { "ike-frag",  AUTO | kv_processed | kv_alias,  kt_enum,  KBF_IKE_FRAG,  &kw_ynf_list },  /* obsolete name */
>    { "fragmentation",  AUTO | kv_processed,  kt_enum,  KBF_IKE_FRAG,  &kw_ynf_list },
> -  { "narrowing",  AUTO,  kt_bool,  KBF_IKEv2_ALLOW_NARROWING,  NOT_ENUM },
> +  { "nonononarrowing",  AUTO,  kt_bool,  KBF_IKEv2_ALLOW_NARROWING,  NOT_ENUM },
>    { "pam-authorize",  AUTO,  kt_bool,  KBF_IKEv2_PAM_AUTHORIZE,  NOT_ENUM },
>    { "sareftrack",  AUTO | kv_processed,  kt_enum,  KBF_SAREFTRACK,  &kw_sareftrack_list },
>    { "pfs",  AUTO,  kt_bool,  KBF_PFS,  NOT_ENUM },
> [build at blueswan libreswan]$ #end of commands
>
> -antony
> _______________________________________________
> Swan-dev mailing list
> Swan-dev at lists.libreswan.org
> https://lists.libreswan.org/mailman/listinfo/swan-dev