[Swan-dev] pluto: ikev2_create_responder_child_state() skip comparing againt self
paul at nohats.ca
Wed Sep 2 21:36:37 EEST 2015
On Wed, 2 Sep 2015, D. Hugh Redelmeier wrote:
> | From: Paul Wouters <paul at vault.libreswan.fi>
> | commit bd1e93b605c4c4aa9d47ee41a89532047c2e825b
> | Author: Paul Wouters <pwouters at redhat.com>
> | Date: Sun Aug 30 21:18:54 2015 -0400
> | pluto: ikev2_create_responder_child_state() skip comparing againt self
> Does this fix a real problem? Does it create new ones? Do we have a
> test case?
No it does not fix a real problem.
It loops over connections to improve "c", so it seems to make sense to
skip over "c" in the list of "all connections" ?
> - the continue should not be on the same line as the if.
> - the second half of the comment line that was broken for length
> ought to be indented to make the structure of the comment clearer.
More information about the Swan-dev