[Swan-dev] should test /etc/ipsec.conf files be stand-alone

[Andrew Cagney]

On 20 October 2015 at 18:16, Paul Wouters <paul at nohats.ca> wrote:
> Making them stand alone will cause important parts to get out of sync.

Well, technically, that's what I'm battling now :-)  If i try to run a
test-suite from anything but /testing, things are out-of-sync.

> We have thought about completely
> removing the includes so that the test cases act as documentation files but didn't decide on doing it.

I should note that I'm not actually against using "include",  I can
see positives and negatives.  If it was't hardwired to a build
directory then that would be fine.  For instance, we could copy the
base configs to /etc/ipsec.d/baseconfigs (or even ln-s the current
test directory) and then use paths to that.

As for eliminating the include, there are always hacks involving
either M4 or CPP trying to give you the best (worst?) of both worlds
...  Lets consider that separately.

> So for now I'm afraid you'll have to tar up
> /testing/baseconfigs/

Except when the root file system is mostly readonly :-)

Andrew

> Sent from my iPhone
>
>> On Oct 20, 2015, at 20:31, Andrew Cagney <andrew.cagney at gmail.com> wrote:
>>
>> Hi,
>>
>> I just noticed that, for tests, the /etc/ipsec.conf file isn't exactly
>> standalone.  For instance, for the test ikev2-04-basic-x509,
>> /etc/ipsec.conf ends with the include:
>>
>>    include    /testing/baseconfigs/all/etc/ipsec.d/ipsec.conf.common
>>
>> which creates problems, for instance:
>>
>> - I'd really like to be able to grab the entire config and run it else where:
>>   ssh west 'cd / ; tar cf - etc/ipsec.d etc/ipsec.conf' | ssh red 'cd
>> / ; tar xpf -'
>>
>> - hard-wiring /testing to a single source tree prevents me from having
>> multiple build/test directories.
>>
>> thoughts,
>> Andrew
>> _______________________________________________
>> Swan-dev mailing list
>> Swan-dev at lists.libreswan.org
>> https://lists.libreswan.org/mailman/listinfo/swan-dev