[Swan-dev] state m/c 2of3: State machine cleanups

[Paul Wouters]

On Tue, 3 Mar 2015, Andrew Cagney wrote:

>>> - cleans up IKE_I and MSG_R along with md->role and st->st_role (new).
>>
>> Could one state object be in two different roles? Like when it sent a
>> delete notify and receiving a DPD/liveness probe?
>
> No.  But there is MSG_R.
>
> "role" is the original role as in the original INITIATOR or RESPONDER.

Perhaps st_o_init or st_orig_i is a better name than? role will (again)
get confused up between "original initiator" and "message responder"
roles.

> It can never change. And md-role had better match st->st_role; if it
> doesn't we should back away from the payload slowly :-).

Right. I was confusing it with the message exchange role. Role is a bad
name!

Paul