[Swan-dev] pointless test failures
D. Hugh Redelmeier
hugh at mimosa.com
Thu Jul 30 21:24:41 EEST 2015
| From: Paul Wouters <paul at nohats.ca>
| > - ... connstate=1 ...
| > + ... connstate=#1 ...
| The constate= seems to have gotten the "#" from our state number which
| is wrong, we should not do that as we dont know for sure how that will
| get interpreted. This was done by you in:
| I'll undo the parts related to audit logs.
Ahh. Part of out UX engineering is that all state numbers presented
in logs start with #. If this exception is necessary, that's OK. But
it would be better if we found that the # would be OK.
It seems unlikely that the structure of the value of constate would
matter to other programs since it is really only an internal Pluto
The format effector used before my change was wrong (d for an
unsigned). Don't revert that part.
| commit 010b9072a71b6b3d4a0dd44987e2c9bc2176229f
| Author: D. Hugh Redelmeier <hugh at mimosa.com>
| Date: Sun Jun 14 18:33:28 2015 -0400
| pluto: tidy printf formatting of so_serial_t (#%lu) and v1 msgid_t
| ("%08" PRIx32)
More information about the Swan-dev