[Swan-dev] EVENT_RETRANSMIT_DELAY_0

[D. Hugh Redelmeier]

| From: Antony Antony <antony at phenome.org>

| > | still working on replacing the use of EVENT_RETRANSMIT_DELAY_0 with 
| > | c->r_interval, however, two instances trips me off.  The retransmit is 
| > | scheduled in 30 seconds, check the #master. That looks odd to me.
| > | 
| > | ikev1_aggr.c  1383 /* Set up a retransmission event, half a minute hence */
| > | ikev1_xauth.c 1010 /* Set up a retransmission event, half a minute hence */

| any idea why aggr_outI1_tail retransmit interval is 30 seconds in 
| comment and the code use 10(EVENT_RETRANSMIT_DELAY_0)? Is there any 
| specific reason for 30 seconds?
| 
| It is the same in xauth_send_status comment suggest 30 code is 10. Check 
| the #master
| 
| And in modecfg_send_request it is actually EVENT_RETRANSMIT_DELAY_0 *

I anwered that in the message you partially quoted:

> I get blamed for those comments but all I did was correct the English.
> I changed "henceforth" to "hence".  See
> 2e586b2c37ca7eae5e50613f1e68aff52b7fea63.
> 
> The comment and the code (which disagree!) were added
> in almost a decade ago in 241fba64a3c8c993db820343b76063d51475d843 and
> 9884278826e09e5dd78fcbc3d5c38310e12527ce.
> 
> Fix the comments.  Use a retransmission time that makes sense.

To make it clearer: the comment was wrong at birth.
EVENT_RETRANSMIT_DELAY_0 was 10 seconds in FreeS/WAN and doesn't seem to 
have changed.